Do not delete nova server on create fail

To keep in line with the behaviour of other resources,
a nova server should only be deleted on resource delete.

Fixes bug: #1215132

Change-Id: Ic478754b7b96001fa0d4110a66d008609de7b482

heat/engine/resources/instance.py

@@ -311,9 +311,6 @@ def _check_active(self, cookie):
                 fault = getattr(server, 'fault', {})
                 message = fault.get('message', 'Unknown')
                 code = fault.get('code', 500)
-                delete = scheduler.TaskRunner(
-                    nova_utils.delete_server, server)
-                delete(wait_time=0.2)
                 exc = exception.Error(_("Build of server %(server)s failed: "
                                         "%(message)s (%(code)s)") %
                                       dict(server=server.name,

heat/tests/test_instance.py

@@ -16,7 +16,6 @@
 
 import mox
 
-from heat.engine import clients
 from heat.engine import environment
 from heat.tests.v1_1 import fakes
 from heat.common import exception
@@ -232,8 +231,6 @@ def test_instance_create_error_status(self):
         }
         self.m.StubOutWithMock(return_server, 'get')
         return_server.get()
-        return_server.get().AndRaise(
-            clients.novaclient.exceptions.NotFound('test'))
         self.m.ReplayAll()
 
         self.assertRaises(exception.Error,
@@ -250,8 +247,6 @@ def test_instance_create_error_no_fault(self):
 
         self.m.StubOutWithMock(return_server, 'get')
         return_server.get()
-        return_server.get().AndRaise(
-            clients.novaclient.exceptions.NotFound('test'))
         self.m.ReplayAll()
 
         try: