Enable Deletion of Services with Endpoints

fixes Bug #1019475 Allows the user to delete a service that has endpoints. Change-Id: If2d669e50f73ea5bb7b269f941a3b2710808a98a
openstack · Oct 25, 2012 · f9a9e7f · f9a9e7f
1 parent 7db2f6a
commit f9a9e7f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/keystone/catalog/backends/sql.py b/keystone/catalog/backends/sql.py
@@ -95,6 +95,7 @@ def get_service(self, service_id):
     def delete_service(self, service_id):
         session = self.get_session()
         with session.begin():
+            session.query(Endpoint).filter_by(service_id=service_id).delete()
             if not session.query(Service).filter_by(id=service_id).delete():
                 raise exception.ServiceNotFound(service_id=service_id)
             session.flush()

diff --git a/tests/test_backend_sql.py b/tests/test_backend_sql.py
@@ -209,3 +209,16 @@ def test_get_catalog_without_endpoint(self):
                          None)
         self.assertEqual(catalog[region][service_type]['internalURL'],
                          None)
+
+    def test_delete_service_with_endpoints(self):
+        self.catalog_api.create_service('c', {"id": "c", "desc": "a1",
+                                        "name": "d"})
+        self.catalog_api.create_endpoint('d', {"id": "d", "region": None,
+                                         "service_id": "c", "adminurl": None,
+                                         "internalurl": None,
+                                         "publicurl": None})
+        self.catalog_api.delete_service("c")
+        self.assertRaises(exception.ServiceNotFound,
+                          self.catalog_man.delete_service, {}, "c")
+        self.assertRaises(exception.EndpointNotFound,
+                          self.catalog_man.delete_endpoint, {}, "d")