Fix access to lifetime dict in update_ipsecpolicy method

Also add corresponding unit test. Change-Id: Ie1141b5034415ccf3039a71dfedc47cfb2ca7a88 Closes-Bug: #1237912
openstack · Oct 10, 2013 · 48e36b5 · 48e36b5
1 parent ba42782
commit 48e36b5
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 5 deletions.
diff --git a/neutron/db/vpn/vpn_db.py b/neutron/db/vpn/vpn_db.py
@@ -504,7 +504,7 @@ def update_ipsecpolicy(self, context, ipsecpolicy_id, ipsecpolicy):
                 if lifetime_info:
                     if lifetime_info.get('units'):
                         ipsecp['lifetime_units'] = lifetime_info['units']
-                    if lifetime_info('value'):
+                    if lifetime_info.get('value'):
                         ipsecp['lifetime_value'] = lifetime_info['value']
                 ipsecp_db.update(ipsecp)
         return self._make_ipsecpolicy_dict(ipsecp_db)

diff --git a/neutron/tests/unit/db/vpn/test_db_vpnaas.py b/neutron/tests/unit/db/vpn/test_db_vpnaas.py
@@ -515,9 +515,13 @@ def test_update_ikepolicy(self):
                 ('phase1_negotiation_mode', 'main'),
                 ('ike_version', 'v1'),
                 ('pfs', 'group5'),
-                ('tenant_id', self._tenant_id)]
+                ('tenant_id', self._tenant_id),
+                ('lifetime', {'units': 'seconds',
+                              'value': 60})]
         with self.ikepolicy(name=name) as ikepolicy:
-            data = {'ikepolicy': {'name': name}}
+            data = {'ikepolicy': {'name': name,
+                                  'lifetime': {'units': 'seconds',
+                                               'value': 60}}}
             req = self.new_update_request("ikepolicies",
                                           data,
                                           ikepolicy['ikepolicy']['id'])
@@ -699,16 +703,37 @@ def test_update_ipsecpolicy(self):
                 ('encapsulation_mode', 'tunnel'),
                 ('transform_protocol', 'esp'),
                 ('pfs', 'group5'),
-                ('tenant_id', self._tenant_id)]
+                ('tenant_id', self._tenant_id),
+                ('lifetime', {'units': 'seconds',
+                              'value': 60})]
         with self.ipsecpolicy(name=name) as ipsecpolicy:
-            data = {'ipsecpolicy': {'name': name}}
+            data = {'ipsecpolicy': {'name': name,
+                                    'lifetime': {'units': 'seconds',
+                                                 'value': 60}}}
             req = self.new_update_request("ipsecpolicies",
                                           data,
                                           ipsecpolicy['ipsecpolicy']['id'])
             res = self.deserialize(self.fmt, req.get_response(self.ext_api))
             for k, v in keys:
                 self.assertEqual(res['ipsecpolicy'][k], v)
 
+    def test_update_ipsecpolicy_lifetime(self):
+        with self.ipsecpolicy() as ipsecpolicy:
+            data = {'ipsecpolicy': {'lifetime': {'units': 'seconds'}}}
+            req = self.new_update_request("ipsecpolicies",
+                                          data,
+                                          ipsecpolicy['ipsecpolicy']['id'])
+            res = self.deserialize(self.fmt, req.get_response(self.ext_api))
+            self.assertEqual(res['ipsecpolicy']['lifetime']['units'],
+                             'seconds')
+
+            data = {'ipsecpolicy': {'lifetime': {'value': 60}}}
+            req = self.new_update_request("ipsecpolicies",
+                                          data,
+                                          ipsecpolicy['ipsecpolicy']['id'])
+            res = self.deserialize(self.fmt, req.get_response(self.ext_api))
+            self.assertEqual(res['ipsecpolicy']['lifetime']['value'], 60)
+
     def test_create_ipsecpolicy_with_invalid_values(self):
         """Test case to test invalid values."""
         name = 'ipsecpolicy1'