Skip to content

Commit

Permalink
Sync dhcp_agent.ini with the codes
Browse files Browse the repository at this point in the history
Add an option item into dhcp_agent.ini to sync with the codes.
* Add ovs_integration_bridge in /etc/dhcp_agent.ini
* Add corresponding unit test

Change-Id: Ia78e7ca6c1fcbeca3e962f870a393e44183d719c
closes-Bug: #1256197
  • Loading branch information
Hui HX Xiang committed Dec 5, 2013
1 parent 6451ece commit 5c43242
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 0 deletions.
3 changes: 3 additions & 0 deletions etc/dhcp_agent.ini
Expand Up @@ -15,6 +15,9 @@
# BigSwitch/Floodlight)
# interface_driver = neutron.agent.linux.interface.OVSInterfaceDriver

# Name of Open vSwitch bridge to use
# ovs_integration_bridge = br-int

# Use veth for an OVS interface or not.
# Support kernels with limited namespace support
# (e.g. RHEL 6.5) so long as ovs_use_veth is set to True.
Expand Down
25 changes: 25 additions & 0 deletions neutron/tests/unit/test_linux_interface.py
Expand Up @@ -110,6 +110,31 @@ def test_plug_with_ns(self):
def test_plug_alt_bridge(self):
self._test_plug(bridge='br-foo')

def test_plug_configured_bridge(self):
br = 'br-v'
self.conf.set_override('ovs_use_veth', False)
self.conf.set_override('ovs_integration_bridge', br)
self.assertEqual(self.conf.ovs_integration_bridge, br)

def device_exists(dev, root_helper=None, namespace=None):
return dev == br

ovs = interface.OVSInterfaceDriver(self.conf)
with mock.patch.object(ovs, '_ovs_add_port') as add_port:
self.device_exists.side_effect = device_exists
ovs.plug('01234567-1234-1234-99',
'port-1234',
'tap0',
'aa:bb:cc:dd:ee:ff',
bridge=None,
namespace=None)

add_port.assert_called_once_with('br-v',
'tap0',
'port-1234',
'aa:bb:cc:dd:ee:ff',
internal=True)

def _test_plug(self, additional_expectation=[], bridge=None,
namespace=None):

Expand Down

0 comments on commit 5c43242

Please sign in to comment.