Do not allow blank adminPass attribute on set password

Fixes bug 985263 Change-Id: I846248a4b8cb22fcaca9e51cc477813f80f6d602
openstack · Apr 18, 2012 · 090bef6 · 090bef6
1 parent ab7e590
commit 090bef6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/nova/api/openstack/compute/servers.py b/nova/api/openstack/compute/servers.py
@@ -259,7 +259,7 @@ def _action_create_image(self, node):
         return self._deserialize_image_action(node, ('name',))
 
     def _action_change_password(self, node):
-        if not node.hasAttribute("adminPass"):
+        if not node.getAttribute("adminPass"):
             raise AttributeError("No adminPass was specified in request")
         return {"adminPass": node.getAttribute("adminPass")}
 

diff --git a/nova/tests/api/openstack/compute/test_server_actions.py b/nova/tests/api/openstack/compute/test_server_actions.py
@@ -758,6 +758,16 @@ def test_change_pass_no_pass(self):
                           serial_request,
                           'action')
 
+    def test_change_pass_empty_pass(self):
+        serial_request = """<?xml version="1.0" encoding="UTF-8"?>
+                <changePassword
+                    xmlns="http://docs.openstack.org/compute/api/v1.1"
+                    adminPass=""/> """
+        self.assertRaises(AttributeError,
+                          self.deserializer.deserialize,
+                          serial_request,
+                          'action')
+
     def test_reboot(self):
         serial_request = """<?xml version="1.0" encoding="UTF-8"?>
                 <reboot