Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor security group api not to raise http exceptions
The SecurityGroupAPI had been raising http exceptions, resulting in a difference in behavior depending on the driver being used: nova or quantum. The nova driver re-raises nova exceptions by default, while the quantum driver was raising the built-in http exceptions. Since servers.py handles nova exceptions, in some cases the quantum driver's http exceptions weren't being handled and resulted in a different http return code to the user. Both SecurityGroupAPI classes inherit from NativeSecurityGroupExceptions and call its static methods to raise exceptions. This change refactors SecurityGroupAPI to raise nova exceptions by modifying NativeSecurityGroupExceptions. The nova exceptions are then translated to http exceptions in the security group wsgi extension. Fixes bug 1183347 Change-Id: I7177183154b4c41037623f443cf9958ac457a020
- Loading branch information
Melanie Witt
committed
Jun 22, 2013
1 parent
cefb051
commit 3401cca
Showing
1 changed file
with
75 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters