Skip to content

Commit

Permalink
Finish AUTHORS transition.
Browse files Browse the repository at this point in the history
The code to generate the authors file from the git changelog has been in the
tree and running for a few weeks now. Somehow the removal of the authors
test and and the MANIFEST.in file were wrong though. This should clean that
up.

Fixes bug 920757.

Change-Id: I66c388c1c81804f8dabc52b5ee25c7f394921e11
  • Loading branch information
emonty committed Jul 5, 2012
1 parent 980c762 commit 3456b66
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 264 deletions.
2 changes: 2 additions & 0 deletions .gitignore
@@ -1,6 +1,8 @@
*.pyc
*.DS_Store
local_settings.py
Authors
AUTHORS
ChangeLog
MANIFEST
CA/
Expand Down
236 changes: 0 additions & 236 deletions Authors

This file was deleted.

2 changes: 1 addition & 1 deletion MANIFEST.in
@@ -1,4 +1,4 @@
include Authors
include AUTHORS
include ChangeLog
exclude .gitignore
exclude .gitreview
Expand Down
27 changes: 0 additions & 27 deletions nova/tests/test_misc.py
Expand Up @@ -42,33 +42,6 @@ def test_exceptions_raise(self):


class ProjectTestCase(test.TestCase):
def test_authors_up_to_date(self):
topdir = os.path.normpath(os.path.dirname(__file__) + '/../../')
missing = set()
contributors = set()
mailmap = utils.parse_mailmap(os.path.join(topdir, '.mailmap'))
authors_file = open(os.path.join(topdir,
'Authors'), 'r').read().lower()

if os.path.exists(os.path.join(topdir, '.git')):
for email in commands.getoutput('git log --format=%ae').split():
if not email:
continue
if "jenkins" in email and "openstack.org" in email:
continue
email = '<' + email.lower() + '>'
contributors.add(utils.str_dict_replace(email, mailmap))
else:
return

for contributor in contributors:
if contributor == 'nova-core':
continue
if not contributor in authors_file:
missing.add(contributor)

self.assertTrue(len(missing) == 0,
'%r not listed in Authors' % missing)

def test_all_migrations_have_downgrade(self):
topdir = os.path.normpath(os.path.dirname(__file__) + '/../../')
Expand Down

0 comments on commit 3456b66

Please sign in to comment.