Makes common/cfg.py raise AttributeError

* fixes bug 915039 * includes test Change-Id: I67b886be3b5af3763f52fffe54085975d61d61eb
openstack · Jan 11, 2012 · 4d01531 · 4d01531
1 parent 0bbf67c
commit 4d01531
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/nova/common/cfg.py b/nova/common/cfg.py
@@ -229,7 +229,7 @@ def __str__(self):
         return ret
 
 
-class NoSuchOptError(Error):
+class NoSuchOptError(Error, AttributeError):
     """Raised if an opt which doesn't exist is referenced."""
 
     def __init__(self, opt_name, group=None):

diff --git a/nova/tests/test_cfg.py b/nova/tests/test_cfg.py
@@ -598,6 +598,11 @@ def test_unknown_attr(self):
         self.assertFalse(hasattr(self.conf, 'foo'))
         self.assertRaises(NoSuchOptError, getattr, self.conf, 'foo')
 
+    def test_unknown_attr_is_attr_error(self):
+        self.conf([])
+        self.assertFalse(hasattr(self.conf, 'foo'))
+        self.assertRaises(AttributeError, getattr, self.conf, 'foo')
+
     def test_unknown_group_attr(self):
         self.conf.register_group(OptGroup('blaa'))