Merge "Fixes bug 871877"

openstack · Nov 10, 2011 · 9334893 · 9334893
2 parents 41b4af1 + 6e7b038
commit 9334893
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 0 deletions.
diff --git a/Authors b/Authors
@@ -4,6 +4,7 @@ Adam Johnson <adjohn@gmail.com>
 Ahmad Hassan <ahmad.hassan@hp.com>
 Alex Meade <alex.meade@rackspace.com>
 Alexander Sakhnov <asakhnov@mirantis.com>
+Alvaro Lopez Garcia <aloga@ifca.unican.es>
 Andrey Brindeyev <abrindeyev@griddynamics.com>
 Andy Smith <code@term.ie>
 Andy Southgate <andy.southgate@citrix.com>

diff --git a/nova/network/manager.py b/nova/network/manager.py
@@ -1217,6 +1217,7 @@ def allocate_fixed_ip(self, context, instance_id, network, **kwargs):
             self.db.fixed_ip_associate(context,
                                        address,
                                        instance_id,
+                                       network['id'],
                                        reserved=True)
         else:
             address = kwargs.get('address', None)

diff --git a/nova/tests/test_network.py b/nova/tests/test_network.py
@@ -298,6 +298,7 @@ def test_vpn_allocate_fixed_ip(self):
                               'virtual_interface_get_by_instance_and_network')
 
         db.fixed_ip_associate(mox.IgnoreArg(),
+                              mox.IgnoreArg(),
                               mox.IgnoreArg(),
                               mox.IgnoreArg(),
                               reserved=True).AndReturn('192.168.0.1')
@@ -312,6 +313,19 @@ def test_vpn_allocate_fixed_ip(self):
         network['vpn_private_address'] = '192.168.0.2'
         self.network.allocate_fixed_ip(None, 0, network, vpn=True)
 
+    def test_vpn_allocate_fixed_ip_no_network_id(self):
+        network = dict(networks[0])
+        network['vpn_private_address'] = '192.168.0.2'
+        network['id'] = None
+        context_admin = context.RequestContext('testuser', 'testproject',
+                is_admin=True)
+        self.assertRaises(exception.FixedIpNotFoundForNetwork,
+                self.network.allocate_fixed_ip,
+                context_admin,
+                0,
+                network,
+                vpn=True)
+
     def test_allocate_fixed_ip(self):
         self.mox.StubOutWithMock(db, 'fixed_ip_associate_pool')
         self.mox.StubOutWithMock(db, 'fixed_ip_update')