Add a note explaining why unhandled exceptions shouldn't be returned

to users. For future developers so they don't re-introduce a bug by accident. Change-Id: I24f03adcc795db6252be988c076043bb74026733
openstack · Jan 26, 2012 · cefc979 · cefc979
1 parent 7b5e907
commit cefc979
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/nova/api/openstack/__init__.py b/nova/api/openstack/__init__.py
@@ -42,6 +42,10 @@ def __call__(self, req):
         except Exception as ex:
             LOG.exception(_("Caught error: %s"), unicode(ex))
             exc = webob.exc.HTTPInternalServerError()
+            # NOTE(johannes): We leave the explanation empty here on
+            # purpose. It could possibly have sensitive information
+            # that should not be returned back to the user. See
+            # bugs 868360 and 874472
             return wsgi.Fault(exc)