Use 201 instead of 200 for action create of flavor-manage v3

All of v3 create action should return 201. Fix this for flavor-manage v3 Closes-bug: 1252162 DocImpact Change-Id: I4fc698abdf89c93cb6ea0990ae43960f8c651d95
openstack · Nov 18, 2013 · f0b35c8 · f0b35c8
1 parent 6fbb0b1
commit f0b35c8
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/nova/api/openstack/compute/plugins/v3/flavor_manage.py b/nova/api/openstack/compute/plugins/v3/flavor_manage.py
@@ -51,6 +51,7 @@ def _delete(self, req, id):
 
         return webob.Response(status_int=204)
 
+    @wsgi.response(201)
     @wsgi.action("create")
     @extensions.expected_errors((400, 409))
     @wsgi.serializers(xml=flavors_api.FlavorTemplate)

diff --git a/nova/tests/api/openstack/compute/plugins/v3/test_flavor_manage.py b/nova/tests/api/openstack/compute/plugins/v3/test_flavor_manage.py
@@ -256,7 +256,7 @@ def test_create_flavor_name_with_leading_trailing_whitespaces(self):
         req.method = 'POST'
         req.body = jsonutils.dumps(request_dict)
         res = req.get_response(self.app)
-        self.assertEqual(res.status_code, 200)
+        self.assertEqual(res.status_code, 201)
         body = jsonutils.loads(res.body)
         self.assertEqual("test", body["flavor"]["name"])
 

diff --git a/nova/tests/integrated/v3/test_flavor_access.py b/nova/tests/integrated/v3/test_flavor_access.py
@@ -39,7 +39,7 @@ def _create_flavor(self):
                                  "flavor-access-create-req",
                                  subs)
         subs.update(self._get_regexes())
-        self._verify_response("flavor-access-create-resp", subs, response, 200)
+        self._verify_response("flavor-access-create-resp", subs, response, 201)
 
     def test_flavor_access_create(self):
         self._create_flavor()

diff --git a/nova/tests/integrated/v3/test_flavor_manage.py b/nova/tests/integrated/v3/test_flavor_manage.py
@@ -30,7 +30,7 @@ def _create_flavor(self):
                                  "flavor-create-post-req",
                                  subs)
         subs.update(self._get_regexes())
-        self._verify_response("flavor-create-post-resp", subs, response, 200)
+        self._verify_response("flavor-create-post-resp", subs, response, 201)
 
     def test_create_flavor(self):
         # Get api sample to create a flavor.

diff --git a/nova/tests/integrated/v3/test_flavor_rxtx.py b/nova/tests/integrated/v3/test_flavor_rxtx.py
@@ -44,7 +44,7 @@ def test_flavors_rxtx_create(self):
                                  'flavor-rxtx-post-req',
                                  subs)
         subs.update(self._get_regexes())
-        self._verify_response('flavor-rxtx-post-resp', subs, response, 200)
+        self._verify_response('flavor-rxtx-post-resp', subs, response, 201)
 
 
 class FlavorRxtxXmlTest(FlavorRxtxJsonTest):