Skip to content

Commit

Permalink
Enable/disable services/endpoints (bug 1048662)
Browse files Browse the repository at this point in the history
Change-Id: I664b7f7dfa281a4481bfc37eab0948a901f1c0c5
  • Loading branch information
dolph committed Oct 10, 2012
1 parent 4636008 commit 62c55bc
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 8 deletions.
18 changes: 12 additions & 6 deletions keystoneclient/v3/endpoints.py
Expand Up @@ -29,6 +29,7 @@ class Endpoint(base.Resource):
* region: geographic location of the endpoint
* service_id: service to which the endpoint belongs
* url: fully qualified service endpoint
* enabled: determines whether the endpoint appears in the catalog
"""
pass
Expand All @@ -46,34 +47,39 @@ def _validate_interface(self, interface):
msg = msg % ', '.join(VALID_INTERFACES)
raise Exception(msg)

def create(self, service, url, name=None, interface=None, region=None):
def create(self, service, url, name=None, interface=None, region=None,
enabled=True):
self._validate_interface(interface)
return super(EndpointManager, self).create(
service_id=base.getid(service),
interface=interface,
url=url,
region=region)
region=region,
enabled=enabled)

def get(self, endpoint):
return super(EndpointManager, self).get(
endpoint_id=base.getid(endpoint))

def list(self, service=None, name=None, interface=None, region=None):
def list(self, service=None, name=None, interface=None, region=None,
enabled=None):
self._validate_interface(interface)
return super(EndpointManager, self).list(
service_id=base.getid(service),
interface=interface,
region=region)
region=region,
enabled=enabled)

def update(self, endpoint, service=None, url=None, name=None,
interface=None, region=None):
interface=None, region=None, enabled=None):
self._validate_interface(interface)
return super(EndpointManager, self).update(
endpoint_id=base.getid(endpoint),
service_id=base.getid(service),
interface=interface,
url=url,
region=region)
region=region,
enabled=enabled)

def delete(self, endpoint):
return super(EndpointManager, self).delete(
Expand Down
7 changes: 5 additions & 2 deletions keystoneclient/v3/services.py
Expand Up @@ -24,6 +24,7 @@ class Service(base.Resource):
* id: a uuid that identifies the service
* name: user-facing name of the service (e.g. Keystone)
* type: 'compute', 'identity', etc
* enabled: determines whether the service appears in the catalog
"""
pass
Expand All @@ -35,21 +36,23 @@ class ServiceManager(base.CrudManager):
collection_key = 'services'
key = 'service'

def create(self, name, type, **kwargs):
def create(self, name, type, enabled=True, **kwargs):
return super(ServiceManager, self).create(
name=name,
type=type,
enabled=enabled,
**kwargs)

def get(self, service):
return super(ServiceManager, self).get(
service_id=base.getid(service))

def update(self, service, name=None, type=None, **kwargs):
def update(self, service, name=None, type=None, enabled=None, **kwargs):
return super(ServiceManager, self).update(
service_id=base.getid(service),
name=name,
type=type,
enabled=enabled,
**kwargs)

def delete(self, service):
Expand Down
1 change: 1 addition & 0 deletions tests/v3/test_endpoints.py
Expand Up @@ -19,6 +19,7 @@ def new_ref(self, **kwargs):
kwargs.setdefault('region', uuid.uuid4().hex)
kwargs.setdefault('service_id', uuid.uuid4().hex)
kwargs.setdefault('url', uuid.uuid4().hex)
kwargs.setdefault('enabled', True)
return kwargs

def test_create_public_interface(self):
Expand Down
1 change: 1 addition & 0 deletions tests/v3/test_services.py
Expand Up @@ -17,4 +17,5 @@ def new_ref(self, **kwargs):
kwargs = super(ServiceTests, self).new_ref(**kwargs)
kwargs.setdefault('name', uuid.uuid4().hex)
kwargs.setdefault('type', uuid.uuid4().hex)
kwargs.setdefault('enabled', True)
return kwargs

0 comments on commit 62c55bc

Please sign in to comment.