Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anatomy schema improvements #851

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukewarlow
Copy link
Collaborator

@lukewarlow lukewarlow commented Sep 28, 2023

Fixes #845

Legacy Anatomies:

image

New Antomies:

image

@lukewarlow lukewarlow marked this pull request as ready for review October 10, 2023 21:43
@lukewarlow
Copy link
Collaborator Author

Blocked by #850

@lukewarlow
Copy link
Collaborator Author

Follow up issue to work out the UI improvements #874

@lukewarlow lukewarlow changed the title Anatomy improvements Anatomy schema improvements Oct 12, 2023
@lukewarlow lukewarlow force-pushed the anatomy-improvements branch 3 times, most recently from 55969bc to 68726d5 Compare October 15, 2023 14:29
@lukewarlow
Copy link
Collaborator Author

See #885 for usage of this new schema to see if there's any core requirements missing. For me it's the "slot" concept that I think does need to exist. It largely doesn't exist in browsers atm (aside from default slot) but it does get uses for <selectlist> and for <details>. I also imagine it's a much bigger part in other design systems.

My gut feeling is that the current approach doesn't demonstrate this level of flexibility in the anatomies.

@lukewarlow
Copy link
Collaborator Author

@gregwhitworth I've been looking into using that custom element manifest for our definitions and I think it's definitely viable but it would be more a thing of importing defintions of specific things and incorporating our own spin on it. (The manifest can't be used for nesting of structure as a wholesale thing for example).

Gonna require me to sit down and give it some thought how best to incorporate it all so for I think for now we should try and get this and the browser anatomies merged so we've got something we can use for now. Then I can make a follow up that adjusts it to utilitise the custom element manifest definitions where possible.

@lukewarlow
Copy link
Collaborator Author

@gregwhitworth are you able to approve this when you've got the time. Then we can land the basic browser data as a follow up.

I will separately take a look into a slightly bigger refactor using the custom element schema but that will require a bit more work and I don't want to block having the browser data available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve design system anatomy JSON Schema
1 participant