Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a number input explainer #861

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukewarlow
Copy link
Collaborator

@lukewarlow lukewarlow commented Oct 5, 2023

Add a number input explainer along with a proposed anatomy

See #784 for the iniitial research PR. Once that's landed this changeset should get simpler.

@lukewarlow
Copy link
Collaborator Author

https://docs.google.com/document/d/13_Dxxszw2j8ELYUi2FAKPkeUZ1ddcKUnX_ZRGqPErXs/edit - Google doc to discuss this stuff further to come up with a good explainer @gregwhitworth (just copying from previous PR so it doesn't get lost)

@gregwhitworth
Copy link
Member

I'm really liking this. That said, it seems like you're asking more questions rather than making a statement in your explainer. You landed the research. The proposal should link out to it, put your proposed anatomy in there and remove the "cruft". By all means have supporting arguments for why you're making the decisions you are (eg: making them siblings, etc).

@lukewarlow
Copy link
Collaborator Author

That makes sense, when I'm back I'll clean this up and get it ready to land an initial explainer, and then once we get stuff like the browser anatomies merged it'll provide even more evidence for this.

@lukewarlow
Copy link
Collaborator Author

Waiting on #784

GarthDB pushed a commit to GarthDB/open-ui that referenced this pull request Mar 28, 2024
Move H2 header out of JSX component. Right now MDX does not apply
rehype plugings over JSX content.

Fix openui#861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants