Change alt attributes to be empty
#943
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YummyBacon5
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
|
Agree with the complete redundancy here; but I'm curious if we should add an alt of "flag" to the image? This would result with an AT reading of "Image ... Flag ... USA, etc". I think I prefer your approach but would like @josepharhar to weigh in since he's primarily making the |
|
These shouldnt have alt values. Flag isn’t useful here unless the intent is to choose a flag |
scottaohara
approved these changes
Nov 17, 2023
|
Not a blocker here but we should add label elements to each of the selectlists |
coliff
approved these changes
Feb 7, 2024
|
Hey, please can this PR be merged now? Since it has been months |
|
@mfreed7 or @gregwhitworth would be good if one of you could approve so we can merge :) |
Based on this reply, this LGTM. |
mfreed7
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For these images, the
altattribute should be empty because these images are decorational. Since all the info is already conveyed through the option's text.Currently, a screen reader would announce "flag of USA USA" as the accessible name, which is verbose.