New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable simplex 2d noise for Synthetic dataset #1056
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: yzheng124 <yi.zheng@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be very useful. I am fine with the design but maybe @djdameln might have some thoughts about this. There is one issue with circular import though when I try to run the code.
from torch import Tensor | ||
|
||
try: | ||
from numba import njit, prange |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add numba
to optional requirements. Thoughts @samet-akcay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numba
should be added into requirements, otherwise it would be very slow ...
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. I am almost fine with the changes.
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: yzheng124 <yi.zheng@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
Signed-off-by: Kang Wenjing <wenjing.kang@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a simple yet useful extension of the random noise augmentation mechanism. We might need to make some changes to the configuration part in the config.yaml to ensure compatibility with other hackathon submissions, but we will sort this out on our side.
Description
This enhances the current synthetic dataset noise generation method with simplex 2d noise:
references:
https://en.wikipedia.org/wiki/Simplex_noise
https://github.com/lmas/opensimplex
Need to discuss whether the init function of AnomalibDataModule is proper. if proper, needs to enable other dataset other than mvtec.
Some other thoughts:
We may need add some APIs to determine mixing ratios of two different types of noises, i.e. perlin2d and simplex2d, instead of using only one type of noise.
Changes
Checklist