Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ensembling methods for tiling to Anomalib #1226

Open
wants to merge 166 commits into
base: main
Choose a base branch
from

Conversation

blaz-r
Copy link
Contributor

@blaz-r blaz-r commented Aug 1, 2023

Description

This PR adds mechanism to train ensemble of models on tiled images. It is part of Google Summer of Code.

A lot of details on implementation as well as discussion can be accessed in #1131.

Closes #1727

Changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which refactors the code base)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Some things still todo (tests, docs...) but most of the code is ready for review.

  • My code follows the pre-commit style and check guidelines of this project.
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have added a summary of my changes to the CHANGELOG (not for minor changes, docs and tests).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment on the white space. it would be good to make this transparent so it would be well placed with darker backgrounds

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the borders? Because if background would be transparent, then the arrows wouldn't be properly visible.

@kubikub
Copy link

kubikub commented Mar 25, 2024

Hello, is there a chance to see this PR merged soon ? I'm trying to use tilling but without succes.
Many thanks for your great work !

@samet-akcay
Copy link
Contributor

Hi @kubikub, it is blocked by this issue. We need to create a new pipeline interface to run benchmarks, hpo, and tiling etc.
#1732

@pirnerjonas
Copy link
Contributor

we are also very much looking forward to this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ensembling methods for tiling to Anomalib
6 participants