Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinCLIP improvements #1985

Merged
merged 7 commits into from May 16, 2024
Merged

Conversation

djdameln
Copy link
Contributor

πŸ“ Description

Two small improvements to the WinCLIP torch model:

  1. Set device dynamically when collecting text embeddings before inference. This is needed so that setup can be called after the model has been moved to cuda.
  2. Encode the images without gradient in the forward pass. This is to preserve gpu memory when the model has not been set in eval mode by the user.

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@djdameln djdameln requested a review from samet-akcay May 6, 2024 15:35
@adrianboguszewski
Copy link
Contributor

Could we also fix #1641 in this PR?

@samet-akcay samet-akcay enabled auto-merge (squash) May 16, 2024 15:19
@samet-akcay samet-akcay merged commit 28e023e into openvinotoolkit:main May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants