Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Reverse Distillation export to ONNX #1990

Merged
merged 8 commits into from May 14, 2024

Conversation

adrianboguszewski
Copy link
Contributor

πŸ“ Description

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • πŸ”¨ Refactor (non-breaking change which refactors the code base)
  • πŸš€ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”’ Security update

βœ… Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • πŸ“‹ I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • πŸ“š I have made the necessary updates to the documentation (if applicable).
  • πŸ§ͺ I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this!

@samet-akcay
Copy link
Contributor

The tests are failing due to device mismatch somewhere

Signed-off-by: Adrian Boguszewski <adrian.boguszewski@intel.com>
@adrianboguszewski
Copy link
Contributor Author

adrianboguszewski commented May 8, 2024

Let's see if it helps. I cannot test it locally due to a lack of a good GPU

@samet-akcay samet-akcay merged commit 4b884b9 into openvinotoolkit:main May 14, 2024
5 of 7 checks passed
@adrianboguszewski adrianboguszewski deleted the reverse-fix branch May 14, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 ONNX Export for Reverse Distillation and RKDE fails
3 participants