Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meta-plugin revalidate list #24423

Merged
merged 10 commits into from May 14, 2024
Merged

Update meta-plugin revalidate list #24423

merged 10 commits into from May 14, 2024

Conversation

peterchen-intel
Copy link
Contributor

@peterchen-intel peterchen-intel commented May 8, 2024 •
edited

Details:

  • meta-plugins are tested with dedicated test binaries
  • Remove CPU/GPU/TEMPLATE from meta-plugin revalidate list
  • Keep GPU in AUTO-BATCH revalidate list since AUTO-BATCH is enabled by default for GPU throughput mode
  • revalidate: Includes the test cases which can be impacted by the changes in this component
  • build: Includes the dependencies for the test cases of this component

Tickets:

@peterchen-intel
Remove meta-plugin unecessary test cases
82f55dc 
meta-plugins are tested with dedicated test binaries

Signed-off-by: Chen Peter <peter.chen@intel.com>
@peterchen-intel peterchen-intel requested a review from a team as a code owner May 8, 2024 13:35
@github-actions github-actions bot added the category: CI OpenVINO public CI label May 8, 2024
@peterchen-intel peterchen-intel marked this pull request as draft May 8, 2024 13:36
peterchen-intel
peterchen-intel commented May 8, 2024
View reviewed changes
.github/components.yml Show resolved Hide resolved
.github/components.yml Outdated Show resolved Hide resolved
.github/components.yml Show resolved Hide resolved
.github/components.yml Outdated Show resolved Hide resolved
.github/components.yml Show resolved Hide resolved
.github/components.yml Show resolved Hide resolved
peterchen-intel
peterchen-intel commented May 13, 2024
View reviewed changes
.github/components.yml Outdated Show resolved Hide resolved
.github/components.yml Outdated Show resolved Hide resolved
@peterchen-intel peterchen-intel marked this pull request as ready for review May 13, 2024 07:08
ilya-lavrenov
ilya-lavrenov reviewed May 13, 2024
View reviewed changes
.github/components.yml Outdated
@@ -54,26 +54,21 @@ NPU:

HETERO:
revalidate:
- CPU
- GPU
- HETERO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove itself, e.g. if HETERO has changed, it's clear that it needs to be revalidated

peterchen-intel
peterchen-intel commented May 14, 2024
View reviewed changes
.github/components.yml Outdated Show resolved Hide resolved
.github/components.yml Outdated Show resolved Hide resolved
.github/components.yml Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov added this pull request to the merge queue May 14, 2024
@ilya-lavrenov ilya-lavrenov added this to the 2024.2 milestone May 14, 2024
Merged via the queue into openvinotoolkit:master with commit 8c82c60 May 14, 2024
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@riverlijunjie riverlijunjie Awaiting requested review from riverlijunjie

@songbell songbell Awaiting requested review from songbell

@wangleis wangleis Awaiting requested review from wangleis

@zhaixuejun1993 zhaixuejun1993 Awaiting requested review from zhaixuejun1993

@yangwang201911 yangwang201911 Awaiting requested review from yangwang201911

Assignees

@ilya-lavrenov ilya-lavrenov

@dorloff dorloff

Labels
category: CI OpenVINO public CI
Projects
None yet
Milestone
2024.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterchen-intel @ilya-lavrenov @riverlijunjie @dorloff