Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table substitution not work in node-red #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lekhahuynh
Copy link

Reproduce The Error

  1. Install xlsx-template in node-red (3.0.2)
  2. Run substitution table with data is array.
  3. Table not generate in output.

Input:
image
Output:
image

Resolution:
After debug source code i see substitution instanceof Array not work in node-red. I and update function check Array by Array.isArray() and it work ok.

image
image

@kant2002
Copy link
Collaborator

Can I ask you to add test for your scenario?

@lekhahuynh
Copy link
Author

Can I ask you to add test for your scenario?

I know unit test need for any function. But it only change function check array and i see old testing passed. So I think not need to write more test for this case.

Btw, If you think I need add unit test please tell me. I will add test for this scenario. Sorry for my English not good.

@kant2002
Copy link
Collaborator

I think we should try setup CI for node-red then. Are you know any examples on opensource projects how to do that, or article that would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants