-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ Simplify RunScorecard with functional optionals #4106
Conversation
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
This is still a WIP, as I'm thinking about There's also some duplication that happens setting up the scorecard/cron/internal/worker/main.go Lines 202 to 207 in 6815161
|
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
c97d7ef
to
438f838
Compare
In order to automatically create a repo client if one isn't provided, I need to be able to test the Repo type. Lines 382 to 399 in 438f838
|
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
What kind of change does this PR introduce?
breaking change / refactor
What is the current behavior?
See #3717. Ultimately every change to the signature is another breaking change, and this breaking change hopefully stops future breaking changes.
What is the new behavior (if this is a feature change)?**
A new top level entry point:
Run
. The hope is that thepkg
package also gets renamed so it's justscorecard.Run()
instead ofpkg.RunScorecard
orpkg.Run
, but that's not the topic of this PR.This entry point takes a context and a repo to be analyzed. Everything else is optional and can be passed as a list of
WithFoo()
arguments.Which issue(s) this PR fixes
Fixes #3717
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)