-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📊 grapher/regions/latest: Add income group information #2571
Conversation
Staging server:
etl diff: ✅ No differences found= Dataset garden/un/2023-10-30/un_members
= Table un_members
= Dataset garden/war/2024-01-23/nuclear_weapons_treaties
= Table nuclear_weapons_treaties
= Table nuclear_weapons_treaties_country_counts
Legend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile are not included Edited: 2024-04-27 14:43:03 UTC |
The output of this step can be found here: http://staging-site-grapher-regions-income-groups:8881/grapher/regions/latest/regions/regions.csv |
Hi @marcelgerber, regarding codes for income groups, in other places of OWID I have seen "OWID_LIC", "OWID_LMC", "OWID_UMC", "OWID_HIC", for example in FAOSTAT. I don't think those codes are relevant, but it makes me think that maybe these codes have been used also elsewhere, so maybe it's safer to stick to them. This PR is in conflict with #2534. So let me think about both proposals and decide about a good solution. |
Sure, I'll change the entity codes then to keep them consistent. Let me know how you want to proceed in regards to #2534. |
I'd suggest closing this PR, and instead go with #2587 (we can discuss it later). |
Nice. I've read through your proposal, and all of it makes a lot of sense to me. Thank you for thinking this through! |
Hey @marcelgerber you can now access the regions data in https://catalog.ourworldindata.org/external/owid_grapher/latest/regions/regions.csv |
This is working towards owid/owid-grapher#3517.
This is adding the 4 WB income groups as rows to the
regions.csv
file which is only consumed by owid-grapher.These rows get the new entity type
income_group
, which we will then handle in grapher. We mostly care about the members of these income groups; and for these to be up to date, we will want to update this step to use the latestwb/.../income_groups
classification once a new one becomes available.This also assigns new entity codes to these four regions:
OWID_WB_LIC, OWID_WB_LMC, OWID_WB_UMC, OWID_WB_HIC
. The last part of these are the official 3-letter codes that the WB uses for these entities.Changing these entity codes in the future is going to be a major pain, so please let me know if you would want to use different ones instead.