Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (facet) hide legends with a single bin #3569

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented May 3, 2024

Fixes #2594

Hides single-item legends for facetted charts (ok since the entity name is mentioned in the title).

Copy link
Member Author

sophiamersmann commented May 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@owidbot
Copy link
Contributor

owidbot commented May 3, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-line-legend

SVG tester:

Number of differences (default views): 5 (3f3cba)
Number of differences (all views): 155 (247f68)

Edited: 2024-05-13 13:23:15 UTC
Execution time: 1.20 seconds

@sophiamersmann sophiamersmann changed the title 🐛 (line chart) do not show lone legend item 🐛 (facet) hide legends with a single bin May 3, 2024
@sophiamersmann sophiamersmann marked this pull request as ready for review May 13, 2024 13:41
@sophiamersmann sophiamersmann merged commit a269b43 into master May 14, 2024
27 of 35 checks passed
@sophiamersmann sophiamersmann deleted the line-legend branch May 14, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide single-entity legends when appropriate
2 participants