Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deploy-queue): pass transaction into deploy queue #3598

Merged
merged 1 commit into from
May 14, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented May 9, 2024

Fixes #3519.

There were two kinds of calls to deployIfQueueIsNotEmpty - one had the knex transaction properly passed to it; the other didn't.

@owidbot
Copy link
Contributor

owidbot commented May 9, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-fix-staging-deploy-queue

SVG tester: Number of differences (default views): 0

Number of differences (all views): 0

Edited: 2024-05-09 21:58:31 UTC
Execution time: 1.13 seconds

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Damn JS for being so flexible that TS didn't refuse the setTimeout call like this :oldmanshakingfistatsky:

@marcelgerber marcelgerber merged commit 1ed4a34 into master May 14, 2024
32 checks passed
@marcelgerber marcelgerber deleted the fix-staging-deploy-queue branch May 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually triggered deploy in staging gets stuck
3 participants