Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image description optional #3615

Merged
merged 1 commit into from
May 22, 2024
Merged

Make image description optional #3615

merged 1 commit into from
May 22, 2024

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented May 17, 2024

Joe suggested not requiring alt on featured images at all, but not sure if:

  • it's worth the added complexity
  • they are always only presentational

Long term, we might switch to auto-generating the description as you suggested before, but that is a much bigger project we didn't scope out, yet.

Fixes #3201

@rakyi rakyi requested a review from ikesau May 17, 2024 14:26
@owidbot
Copy link
Contributor

owidbot commented May 17, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-optional-img-alt

SVG tester:

Number of differences (default views): 0
Number of differences (all views): 0

Edited: 2024-05-17 14:36:25 UTC
Execution time: 1.13 seconds

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see how we go 🙂

@rakyi rakyi merged commit 646c587 into master May 22, 2024
32 checks passed
@rakyi rakyi deleted the optional-img-alt branch May 22, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make image description/alt text for static visualizations non-mandatory
3 participants