More commas on homepage chart count, hasOutline on archie images

[ikesau]

Changes

• Allows authors to add a grey border around images if desired (See slack)

• Adds commafication to another place in the homepage

[rakyi]

LGTM, except one small comment and the build errors.

[rakyi]

It might be worth to:

• Name this formatNumber or formatQuantity to be less specific, we might decide to change the format in the future

• Use the Intl.NumberFormat API if we are gonna keep reusing this and define the formatter at the top scope to avoid initializing it every time we call the function, see docs:

  Every time toLocaleString is called, it has to perform a search in a big database of localization strings, which is potentially inefficient. When the method is called many times with the same arguments, it is better to create a Intl.NumberFormat object and use its format() method

[owidbot]

Quick links (staging server):

Site	Admin	Wizard

Login: ssh owid@staging-site-ui-updates

• Site-screenshots: https://github.com/owid/site-screenshots/compare/ui-updates
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/ui-updates

SVG tester:

Number of differences (default views): 0
Number of differences (all views): 0

Edited: 2024-05-21 15:00:49 UTC
Execution time: 1.20 seconds