Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work/finder sync ext with socketapi #11263

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Work/finder sync ext with socketapi #11263

wants to merge 2 commits into from

Conversation

erikjv
Copy link
Contributor

@erikjv erikjv commented Oct 5, 2023

No description provided.

@erikjv erikjv added the macOS label Oct 5, 2023
@erikjv erikjv self-assigned this Oct 5, 2023
@erikjv erikjv marked this pull request as draft October 5, 2023 16:37
@erikjv
Copy link
Contributor Author

erikjv commented Oct 5, 2023

Needs rebase after #11262 is merged

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@erikjv
Copy link
Contributor Author

erikjv commented Oct 9, 2023

To do: mention #6343 in the commit message

@TheOneRing
Copy link
Member

Please add a description on why this is needed.
Also I think there was a reason special handling for mac was implemented, could you have a look at the commit history?

@erikjv erikjv requested a review from TheOneRing January 3, 2024 15:49
TheOneRing
TheOneRing requested changes Jan 4, 2024
View reviewed changes
Copy link
Member

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please respond to the above question.

@TheOneRing
Copy link
Member

And this is still marked as a draft and has merge conflicts.

@erikjv
Copy link
Contributor Author

erikjv commented Jan 8, 2024

This depends on #9210 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@erikjv erikjv

Labels
macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikjv @TheOneRing