Pause sync when behind a captive portal #11551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
reviewed
Mar 19, 2024
| @@ -104,6 +104,15 @@ bool Utility::internetConnectionIsMetered() | |||
| return false; | |||
| } | |||
|
|
|||
| bool OCC::Utility::internetThroughCaptivePortal() | |||
There was a problem hiding this comment.
I'm wondering whether the null pointer check justifies the overhead of moving the code to utils.
In the end it hides the use of QNetworkInformation and can make reading the code in the future more complicated (also the utils class is already quire crowded)
This was also done for internetConnectionIsMetered.
TheOneRing
reviewed
Mar 19, 2024
| } | ||
| } | ||
|
|
||
| _ui->pauseSyncWhenBehindCaptivePortalCheckBox->setVisible(false); |
There was a problem hiding this comment.
We need to hide the tls dialog if enabled, I'd also say we need to pause, as util the captive portal is accepted there is no way to sync.
|
This is the wrong solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11533