Adopt Update dialogs to the new modal widget experience #11617
Conversation
erikjv
force-pushed
the
work/adopt-update-dialogs
branch
2 times, most recently
from
82d0c63
to
66e5494
Compare
|
New message box: 
|
|
Update downloaded dialog: 
|
|
Hmm could we use the same icon, the app icon, for both? |
erikjv
force-pushed
the
work/adopt-update-dialogs
branch
from
66e5494
to
5fdd4fe
Compare
|
New screenshots: 
|
| QString txt = tr("<p>A new version of the %1 Client is available.</p>" | ||
| "<p><b>%2</b> is available for download. The installed version is %3.</p>") | ||
| .arg(Utility::escape(Theme::instance()->appNameGUI()), | ||
| Utility::escape(info.versionString()), Utility::escape(Version::versionWithBuildNumber().toString())); | ||
| auto *widget = new NoUrlWidget(ocApp()->gui()->settingsDialog(), txt); | ||
| widget->setAttribute(Qt::WA_DeleteOnClose); |
There was a problem hiding this comment.
Its not a dialog anymore, we should handle its deletion.
| Q_OBJECT | ||
|
|
||
| public: | ||
| explicit NoUrlWidget(QWidget *parent, const QString &statusMessage); |
There was a problem hiding this comment.
What is the meaning of the class name?
There was a problem hiding this comment.
It comes from the method that previously showed the dialog: WindowsUpdater::showNoUrlDialog. It's called from WindowsUpdater::versionInfoArrived, when the info has an empty URL. 🤷♂️
| { | ||
| delete _ui; | ||
| Q_EMIT accepted(); | ||
| close(); |
There was a problem hiding this comment.
We should rather delete the class in the caller than rely on delete on close.
There was a problem hiding this comment.
The removal of the delete is because the _ui is now a QScopedPointer instead of a raw pointer.
Fixes: #11593