Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haiku port #7720

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Haiku port #7720

wants to merge 9 commits into from

Conversation

mmuman
Copy link

@mmuman mmuman commented Feb 4, 2020

I had this already working some months ago, but of course I had to rebase and fix stuff again. Also, I was waiting for my PR on qtkeychain to be merged.

It builds and seems to run, but just hung on me, while it didn't on the initial port, so I will have to investigate.

I wrote a HaikuPorts recipe, but there are still some policy warnings, since the paths that are passed to CMake are not respected on install (we don't have include/ but develop/headers/[x86/], no share/ but data/ instead…).

Comments welcome.

@mmuman
Copy link
Author

mmuman commented Feb 5, 2020

Of course windows doesn't have sys/time.h

@ogoffart
Copy link
Contributor

ogoffart commented Feb 5, 2020

Thank you for the patch.

Everything looks good to me, although i did not really look the haiku specific part in details.

@mmuman
Copy link
Author

mmuman commented Feb 6, 2020

cla-assistant would like additional permissions to:
Gists: Read and write access
Organizations and teams: Read-only access
Commit statuses: Read and write access
Personal user data: Email addresses (read-only)
Repository webhooks and services: Read and write access

Ok, email, but why the rest? Is there any valid reason or is it just a default configuration that nobody cared to fix?

@vaskas
Copy link

vaskas commented Jun 18, 2020

@mmuman since Haiku is now on Qt 5.15 this commit is needed to compile: dea019e

As of today it's not in a release yet (2.6.3 comes without it).

@mmuman
Copy link
Author

mmuman commented Jun 18, 2020

Guess I'll have to rebase.
I'd still like some explanation on the cla bot permissions meanwhile…

Really, cmake should test for this one instead of hardcoding half of the OSes around.
Oddly enough it seems only required on Haiku which doesn't pretend to be POSIX.
Haiku doesn't have inotify, since we use a similar API from BeOS
that predates it y 15 years.
Seems to end up in ~/config/settings/owncloud/owncloud/ now, not sure it fits,
but it's better than removing /tmp.
Autostart is functional now.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mmuman
Copy link
Author

mmuman commented Aug 9, 2020

Just rebased.

I still have some failed tests though, including some crashes, or rather aborts, not sure why yet. Btw, when tests like ChunkingNg crash, they leave like a GB of stuff in /tmp …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants