Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove shelling out from example #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove shelling out from example #117

wants to merge 1 commit into from

Conversation

oxinabox
Copy link
Owner

@oxinabox oxinabox commented Jun 8, 2020

Examples were using shelling out to unzip rather than unpack which seems likely to confuse people into thinking shelling out is a good idea.
unpack is a much better way to do this.

thanks @jlperla for spotting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant