Fix very strange bug with form_for and capture_html (double render) #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the RenderDemo app test the block is rendered 4 times instead of 1. With my patch 2 times. |
|
👍 The same issue with mine. |
|
I'm fixing it now. It almost works. |
|
Yeah, thanks a lot! 💯 |
|
Okay, here's the summary: haml does not suffer from lacking any of these commits (1 capture in tests) slim suffers from both. It doubles the number of captures in erb suffers only from I still don't understand why saves slim and erb. The only idea I have is some kind of runtime optimization. |
nesquena
added a commit
that referenced
this pull request
Mar 26, 2013
|
Merged your changes in a squash commit, thanks for getting this working! I think I can close this now |
hooopo
referenced
this pull request
in robbin/robbin_site
Mar 26, 2013
WaYdotNET
added a commit
to WaYdotNET/padrino-framework
that referenced
this pull request
Mar 26, 2013
* upstream/master: have plugin generator respect root option Fix very strange bug with form_for and capture_html @ujifgc padrino#1177 [padrino-core/rake] Adds lib as a load_path for rake tasks padrino#1185 [form_helpers] Use count instead of size (Closes padrino#1184) [format_helpers] Mark escaped text as html_safe (Closes padrino#1183) Closes padrino#1179 for accidental appended extensions for js urls format activerecord migrate formatting activerecord migration test Thanks to @kenkeiter for bringing up the fact that http_router [is missing PATCH](https://github.com/joshbuddy/http_router/blob/master/lib/http_router/route.rb#L5).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's some code that fails very strangely on padrino edge:
https://github.com/ujifgc/tiny
It's basically a test if a block provided for
form_forexecuted twice:If you visit the app with padrino edge, log shows double CAPTURE.
If you appy my patch, then it's only one CAPTURE.
The bug is very strange and I fail to write any test that would catch it. Also I don't understand how
differs from
Please help me with test and maybe explanation of the patch effect.