New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible regression in javascript_include_tag helper in 0.11 #1179

Closed
bascht opened this Issue Mar 25, 2013 · 3 comments

Comments

Projects
None yet
3 participants
@bascht

bascht commented Mar 25, 2013

Hey folks. Looks like upgrading to Padrino 0.11 broke a helper function I used to include a remote JS file. From 0.11.0 on,

javascript_include_tag "https://example.org/js?key=value"

includes https://example.org/js?key=value.js.

I've added a test case in my fork bascht/padrino-framework@8c57e1e

@dariocravero

This comment has been minimized.

Show comment
Hide comment
@dariocravero

dariocravero Mar 25, 2013

Contributor

Yeah, I've seen that too!.. Thanks for opening an issue on it, I'll look into it soon.

EDIT: I think it's here. Thanks for the test :)

Contributor

dariocravero commented Mar 25, 2013

Yeah, I've seen that too!.. Thanks for opening an issue on it, I'll look into it soon.

EDIT: I think it's here. Thanks for the test :)

@bascht

This comment has been minimized.

Show comment
Hide comment
@bascht

bascht Mar 25, 2013

👍 I was digging through the code of the asset tag helpers, but APPEND_ASSET_EXTENSIONS should have made me suspicious. ;-)

bascht commented Mar 25, 2013

👍 I was digging through the code of the asset tag helpers, but APPEND_ASSET_EXTENSIONS should have made me suspicious. ;-)

@nesquena

This comment has been minimized.

Show comment
Hide comment
@nesquena

nesquena Mar 25, 2013

Member

Ah yes, that's my bad, should be a decently easy fix. I can take a look at it.

Member

nesquena commented Mar 25, 2013

Ah yes, that's my bad, should be a decently easy fix. I can take a look at it.

@nesquena nesquena closed this in 9df9849 Mar 25, 2013

WaYdotNET added a commit to WaYdotNET/padrino-framework that referenced this issue Mar 26, 2013

Merge remote-tracking branch 'upstream/master' into all-custom-error
* upstream/master:
  have plugin generator respect root option
  Fix very strange bug with form_for and capture_html @ujifgc #1177
  [padrino-core/rake] Adds lib as a load_path for rake tasks #1185
  [form_helpers] Use count instead of size (Closes #1184)
  [format_helpers] Mark escaped text as html_safe (Closes #1183)
  Closes #1179 for accidental appended extensions for js urls
  format activerecord migrate
  formatting activerecord migration test
  Thanks to @kenkeiter for bringing up the fact that http_router [is missing PATCH](https://github.com/joshbuddy/http_router/blob/master/lib/http_router/route.rb#L5).

bascht added a commit to findoutwho/hasbeen.in that referenced this issue May 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment