Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have padrino start eval config.ru #1260

Closed
postmodern opened this issue Apr 26, 2013 · 10 comments
Closed

Have padrino start eval config.ru #1260

postmodern opened this issue Apr 26, 2013 · 10 comments
Labels
Milestone

Comments

@postmodern
Copy link
Contributor

I feel that any code included in config.ru should be ran when running the app in development mode.

@dariocravero
Copy link

Mmm, I don't know about that @postmodern. The way I see it, config.ru is there for rackup to pick it up and for application servers to work properly.
What are you trying to achieve? Maybe config/boot.rb or config/apps.rb are a better fit?

@postmodern
Copy link
Contributor Author

I was thinking of adding middleware to config.ru so that it would run before Padrino's middleware.

@christhekeele
Copy link

@postmodern
What you're really looking for, I feel, is something like foreman.

@postmodern
Copy link
Contributor Author

Just trying to use a middleware before Padrino's own middleware, in particular Rack::Protection::AuthenticityToken.

@dariocravero
Copy link

@postmodern and why don't you just ran your app using rackup instead of padrino start? It's virtually the same thing :)

@postmodern
Copy link
Contributor Author

rackup doesn't do reloading, also I could see it confusing developers.

@skade
Copy link
Contributor

skade commented Apr 26, 2013

@postmodern For now, you can use Padrino.use for that, which puts things in front of the whole Padrino stack.

I do, however, get this request quite often and I think its reasonable, because it makes all environments behave the same.

@dariocravero
Copy link

@skade should we plan this for 0.12 maybe?

@skade
Copy link
Contributor

skade commented Apr 26, 2013

Not earlier, it might surprise people.

@DAddYE
Copy link
Member

DAddYE commented Jul 1, 2013

@skade can u work on this?

@ghost ghost assigned skade Jul 1, 2013
@ujifgc ujifgc closed this as completed in 1e4ce6e Feb 18, 2014
ujifgc added a commit that referenced this issue Feb 18, 2014
load config.ru with padrino server, fixes #1260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants