Add :file option as a new delivery_method for mails #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2013 21:47
|
It's brilliant @matthias-guenther!! Thanks! :) What I'd change on it so that it's not that confusing is the path. See the comment on the code. Could you rephrase that? Thanks! |
| # or storing emails locally: | ||
| # | ||
| # set :delivery_method, :file => { | ||
| # :location => "emails", |
There was a problem hiding this comment.
Instead of emails we could use #{Padrino.root}/tmp/emails, thoughts?
There was a problem hiding this comment.
I will try it out locally and if it's working fine, I will make the changes, so that it can be merged!
There was a problem hiding this comment.
Perfect!.. Thanks (as a side note, I did and it worked out fine in here :))
ghost
assigned
|
Amazing stuff! Thanks! :) |
dariocravero
pushed a commit
that referenced
this pull request
May 15, 2013
Add :file option as a new delivery_method for mails
|
I'm glad to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was searching for all possible options for sending mails and stumbled upon the edgerails guide which mentioned methods which aren't still part of the documentation.
I updated the
mailer.rb.tttemplate with an example.Matthias