Fix color support for Windows #1744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need win32console when working with Ruby 2.0 or later. Because Ruby 2.0(or later) on Windows supports ANSI escape sequences. Ref: https://bugs.ruby-lang.org/issues/6418
| # If you want colorize on Windows with Ruby 1.9, please use ansicon: | ||
| # https://github.com/adoxa/ansicon | ||
| # Other ways, add `gem 'win32console'` to your Gemfile. | ||
| if RUBY_PLATFORM =~ /mswin|mingw/ && RUBY_VERSION < '2.0' && ENV['ANSICON'].nil? |
There was a problem hiding this comment.
Is this changing RUBY_PLATFORM =~ /mswin|mingw/ on purpose?
There was a problem hiding this comment.
To support mingw or VC++ compiled Ruby on both 32 and 64 bit Windows platforms.
|
Okay, thanks! |
namusyaka
added a commit
that referenced
this pull request
Aug 18, 2014
Fix color support for Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need win32console when working with Ruby 2.0 or later.
Because Ruby 2.0(or later) on Windows supports ANSI escape sequences.
Ref: https://bugs.ruby-lang.org/issues/6418