New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create minitest generator component #667
Comments
@achiu I suggest to target it to the 10.3, you agree? Sinatra 1.3 will be released soon, are u ready? |
ready! |
@DAddYE @achiu Pushed a minitest component here: https://github.com/padrino/padrino-framework/tree/minitest_component. Can you guys review and test that branch so we can merge it back in? |
@nesquena thanks for the minitest component. I was wondering though about whether it should default use minitest spec or test/unit style. perhaps an option? what do you guys think? |
Yeah I mean there's no easy way to make it an option. It would have to be two separate component choices. Not sure if I want minitest_unit and minitest_spec components. I just went with autorun+spec which is what I think the common case is. Thoughts? |
I think we can make a default like this: describe 'foo bar' do
it 'should do some thing' do
assert Foo.is_true?
end
end So DSL + Asseritions. Bad idea? |
Oh so keep describe/it but switch from |
I think Im right with both, sometimes I use |
OK, I agree that describe/it is better in almost all cases. I also don't have a strong preference for |
switch to use assert/refute assertions instead and merged back to master. closing ticket. |
Awesome, glad to have this closed. Thanks @achiu. |
Thanks @achiu |
We should add a minitest test generator choice, i.e
padrino g project demo -t minitest
which requires the gem unless its 1.9. If you guys agree lets get this in for 0.10.3 or 0.10.4The text was updated successfully, but these errors were encountered: