Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.6 #680

Closed
nesquena opened this issue Sep 24, 2011 · 47 comments
Closed

Release 0.10.6 #680

nesquena opened this issue Sep 24, 2011 · 47 comments
Assignees
Milestone

Comments

@nesquena
Copy link
Member

Placeholder for releasing 0.10.6 once it is ready.

@ghost ghost assigned nesquena Sep 24, 2011
@DAddYE
Copy link
Member

DAddYE commented Jan 21, 2012

@nesquena @achiu we need to release a new version of padrino with AS 3.2 and AR 3.2 (which has new awesome features) soon. Im upgrading generators.

Can you point us few bug to fix before this release?

DAddYE added a commit that referenced this issue Jan 21, 2012
@DAddYE
Copy link
Member

DAddYE commented Jan 21, 2012

@achiu I removed dependency of grit since if Im not wrong uses the bin so for simple usage we can forget it and require less dependencies, that will be the major step for 1.0. You agree?

DAddYE added a commit that referenced this issue Jan 21, 2012
@nesquena
Copy link
Member Author

@DAddYE Yeah I agree, we can release a new version with AR 3.2 support soon and push other things to 0.10.7.

@DAddYE
Copy link
Member

DAddYE commented Jan 22, 2012

Hey @nesquena we are almost ready, can you prepare blog post and changelog?

It's green for you?

@nesquena
Copy link
Member Author

Yeah definitely I will prepare today or tomorrow and make sure everything is green.

@DAddYE
Copy link
Member

DAddYE commented Jan 22, 2012

If you can today would be super great. Thanks!!!

@nesquena
Copy link
Member Author

I also want to migrate a couple projects to use this latest version tomorrow as well before we release. Also @achiu can you test as well.

@nesquena
Copy link
Member Author

@DAddYE Everytime I try to update my latest blog post, I am getting a 'Internal Server Error' so I am unable to edit the post after it is created. Can you take a look?

@DAddYE
Copy link
Member

DAddYE commented Jan 23, 2012

Fixed! Okey, I hope @achiu is available today.

@DAddYE
Copy link
Member

DAddYE commented Jan 23, 2012

I've pushed a prerelease 0.10.6.a

@achiurizo
Copy link
Member

I will confirm with my apps when I get in the office @DAddYE @nesquena

@nesquena
Copy link
Member Author

@DAddYE OK updated the changelog and here's the draft for the release post: http://www.padrinorb.com/blog/padrino-0-10-6-activesupport-3-2-minirecord-html5-helpers-and-bug-fixes Take a look and make sure it's ok. I will green light later today after I convert a few apps to 0.10.6

@nesquena
Copy link
Member Author

Once @achiu confirms as well, I will commence with the release.

@nesquena
Copy link
Member Author

Can we take a look at #676 and #736 before release?

@DAddYE
Copy link
Member

DAddYE commented Jan 23, 2012

sure!

@nesquena
Copy link
Member Author

@DAddYE @achiu @skade Added additional changes to changelog and blog post for the logger and trinidad support.

@nesquena
Copy link
Member Author

And released 0.10.6.b

@nesquena
Copy link
Member Author

@DAddYE Why are we failing all of a sudden on 1.9.3? http://travis-ci.org/#!/padrino/padrino-framework/jobs/566292

@DAddYE
Copy link
Member

DAddYE commented Jan 24, 2012

No idea, on my env everything works great, all test passed + integrations. I think there is something strange in travis, because each build has a different error or failing test.

@nesquena
Copy link
Member Author

@DAddYE OK yeah I like the use of prerelease gems now. Allows us to have a gem published without releasing until we can all test and green light. I tested today and upgraded two apps and didn't run into any problems. Also travis seems to be green except for 1.9.3 which seems to be a fluke. @achiu is going to finish testing tomorrow and then we can do official release.

@DAddYE
Copy link
Member

DAddYE commented Jan 24, 2012

Yep, with the prerelease Im okey so I can test it on production where I need explain feature of AR3.2.

Thanks so much @nesquena !

@nesquena
Copy link
Member Author

Ok, ran travis again and all green: http://travis-ci.org/#!/padrino/padrino-framework/builds/566896 and integration http://travis-ci.org/#!/padrino/padrino-integration/builds/566889 . I don't like how it sometimes is red but still I am glad it all passes now. Also yes, I am glad we can both be happy now using prerelease as a way to guarantee more stable releases. We should do this for every significant release now I think.

@nesquena
Copy link
Member Author

Also updated http://www.padrinorb.com/guides/application-helpers#form-helpers to reflect the new HTML field inputs

@achiurizo
Copy link
Member

@DAddYE @nesquena tested with my apps and seems to be fine on my end from what I can tell. using edge.

@nesquena
Copy link
Member Author

@achiu Thanks man. @DAddYE can you take a look at #768

@nesquena
Copy link
Member Author

@DAddYE Do you see any more outstanding issues? check out the 0.10.6 issues and let me know if you think any of them are serious enough to hold up a release. I will review them tomorrow as well. Oh and update the changelog and blog post as needed for additional commits since it was last updated.

@DAddYE
Copy link
Member

DAddYE commented Feb 23, 2012

No, I've reverted the commit about html5 tags this due to the fact that I figure now lots of w3c errors with html 4 and also with html 5 since some tags like link etc... seems that need to be closed.

However xhtml seems much solid and a standard. No?

Finally I pushed two --pre remember when you release it to compile with ruby 1.8 since 1.9 raises lots of yaml errors when rubygems is not the latest version.

Thanks!

@nesquena
Copy link
Member Author

OK, thanks @DAddYE I am going to test this new version with a few apps and also make sure all the tests are passing for me. Then I will update the changelog and blog post.

@nesquena
Copy link
Member Author

nesquena commented Mar 2, 2012

OK, I have upgraded 2-3 of my apps to the latest prerelease and don't have any problems (except some issues with the reloader layout called with 1 argument, has 0 after a controller reload). Not sure that's tied to this release though so I think we are ready soon.

@achiu is going to upgrade his big app tomorrow and report back here. I will be updating the blog post and changelog over this weekend and release.

@nesquena
Copy link
Member Author

nesquena commented Mar 2, 2012

Also, I re-ran the integration tests and they don't look to be working even though they 'pass': http://travis-ci.org/#!/padrino/padrino-integration/jobs/779134

/home/vagrant/.rvm/gems/ruby-1.9.3-p125/gems/rspec-expectations-2.8.0/lib/rspec/expectations/fail_with.rb:32:in `fail_with': expected: "hi" (RSpec::Expectations::ExpectationNotMetError)
112     got: "<h1>Not Found</h1>" (using ==)
/home/vagrant/.rvm/gems/ruby-1.9.3-p125/gems/rspec-expectations-2.8.0/lib/rspec/expectations/fail_with.rb:32:in `fail_with': expected: "hi" (RSpec::Expectations::ExpectationNotMetError)

Any idea why all the assertions seem to be failing?

@achiurizo
Copy link
Member

@nesquena @DAddYE looks like 0.10.6.e is working for me. I haven't noticed any problems yet. So I can 'green' this

@DAddYE
Copy link
Member

DAddYE commented Mar 2, 2012

Thanks @achiu.

@nesquena I will try tomorrow to fix integrations

@nesquena
Copy link
Member Author

nesquena commented Mar 3, 2012

Ok great, I agree I have it running on enough apps that it seems to be fine. @DAddYE Thanks once we can get the integration tests working again, let's release. I will update the changelog and blog post tomorrow.

@DAddYE
Copy link
Member

DAddYE commented Mar 11, 2012

Ok, I updated integrations, http://travis-ci.org/#!/padrino/padrino-integration

Still we have few problems with reloading, I think this depends from something in AS 3.2 that I should solve in 10.7.

@nesquena
Copy link
Member Author

Ok, thanks will run integration tests and update the changelog / release notes soon. Thanks @DAddYE. Yes, I am running into a lot of reloading problems as well.

@DAddYE
Copy link
Member

DAddYE commented Mar 12, 2012

Fixed reloading issue almost in our integrations, I've only few problems only with AR and Single Table Inheritance ...

@DAddYE
Copy link
Member

DAddYE commented Mar 12, 2012

Btw, nothing that will block 10.6 release.

Can you @nesquena review may commits on data options ? Thanks!

@nesquena
Copy link
Member Author

Yes, np will review today

@DAddYE
Copy link
Member

DAddYE commented Mar 13, 2012

@nesquena thanks!

@DAddYE
Copy link
Member

DAddYE commented Mar 13, 2012

@nesquena can we release it today? Blogpost, twitter, HN, Reddit, Rubyflow & c ;) Thank you man!

@nesquena
Copy link
Member Author

Haha yes I will get to it today or tomorrow I promise and post to everything.

@DAddYE
Copy link
Member

DAddYE commented Mar 13, 2012

Hhaha, no problem man!

@nesquena
Copy link
Member Author

OK, planned to do it tonight but its too late now, i'll get this done tomorrow. Thanks for all your hard work on this last release @DAddYE

@DAddYE
Copy link
Member

DAddYE commented Mar 14, 2012

remember to release padrino as you can so we can have more highlight during the day … in usa timezone :D

@nesquena
Copy link
Member Author

OK

@DAddYE
Copy link
Member

DAddYE commented Mar 16, 2012

Yea!!! Congrats guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants