New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update static resources' url from https://github.com to https://raw.github.com #701
Conversation
When I visit: |
Isn't github be swithing urls as on their blog? try it on the console , $ curl -i https://github.com/padrino/padrino-static/raw/master/js/dojo.js |
You are right, the new url is: https://raw.github.com/padrino/padrino-static/master/js/dojo.js vs here's whats in the pull: https://raw.github.com/padrino/padrino-static/raw/master/js/dojo.js Ah look like you fixed it. |
Looks good now, thanks. |
update static resources' url from https://github.com to https://raw.github.com
also, are the static resources not included on the gems for offline operations? |
That was a mistake on my part which is going to be corrected in a quiet release that contains this change and reincludes static assets. I am also going to add a check that ensures static assets exist from here on out. |
great. thanks |
Ok new version should be release 0.10.5 with your fix and static assets re-included. Can you confirm? |
it works if the static assets are included, which means the get('https://raw.. fails due to SSL verification error on thor's get |
Why do you think there's ssl fails on the get? |
appears to be a open-uri issue as thor uses it. adding these lines require 'openssl' on padrino-gen/generators/cli will fix it. Thou I am not sure if this is the correct way |
switch download of raw resources from https://github.com/ to https://raw.github.com/