set PADRINO_LOG_LEVEL constant by default #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAddYE
added a commit
that referenced
this pull request
Nov 22, 2011
set PADRINO_LOG_LEVEL constant by default
|
Thanks, I think we should comment it so can be easily to uncomment when necessary. |
modeverv
pushed a commit
to modeverv/padrino-framework
that referenced
this pull request
Nov 23, 2011
$ padrino rake mytask -v Fix padrino#720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes after this question:
http://stackoverflow.com/questions/8082848/how-do-i-log-queries-in-a-rake-task-using-datamapper-and-padrino
Basically, I didn't understand why logging was working ok inside the padrino admin but not in a rake file.
I think the PADRINO_LOG_LEVEL constant should be included by default to make it easier to avoid problems like this.