padrino-flash into padrino-core #904
Conversation
|
Good work @lenzcom ! Can you add some tests? Thanks! |
|
Yes, this is a lot of extra code to introduce into Padrino without any tests...we should add tests for this or revert back to using sinatra-flash. What was lacking in sinatra-flash anyhow? What prompted you to replace it @lenzcom |
|
the todo annotation and deprecation notice was the first that let me recognize. Then, while working with the bootstrap branch and WayDotNets update to version 2 of bootstrap I began to include it as submodule into my generated projects. That worked perfectly without to make any big changes to generators and stuff. |
|
@DAddYE I'm going to begin write some test code in just a sec, but be forwarned. I'm not a pro in writing tests. |
|
Seems like there are some existing tests here @Cirex https://github.com/Cirex/padrino-flash/tree/master/spec and that project is pretty good. Why don't we just add padrino-flash to the Gemfile then for now rather than pull in all this code and duplicate the effort? Or I guess we can rewrite the tests that he had in his project? or we could fork the Cirex project and make it officially maintained in the padrino repo? Thoughts @DAddYE? |
|
I prefer to manage it directly because I got always problems with these flash helpers maybe |
|
Ok that makes sense then |
here it is ...