Support keys as symbols when expiring cache #947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct me if I'm wrong but a cached value can be set using either a String and a Symbol. In other words:
cache(:something, 'some value')
is the same as:
cache ('something', 'some value')
I don't know if there's a particular reason not to use Symbols but if you're trying to expire a cached value created using a Symbol key you get an error unless there's an URL on the controller that matches that key, in which case it's even worse since that's not what you're trying to achieve when deleting that key.
I'm attaching a simple patch to support both Symbols and Strings.
Let me know if it should be like that or I'm just missing something.
Thanks