Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid improper checking, fixes #1584 #1591

Merged
merged 3 commits into from Feb 16, 2014
Merged

Avoid improper checking, fixes #1584 #1591

merged 3 commits into from Feb 16, 2014

Conversation

namusyaka
Copy link
Contributor

ref #1584
I fixed a few points as below.

  • Can't destroy generated model.
  • Can't destroy sub application.
  • The tests that are related to #already_exists don't work well.

@ujifgc
Copy link
Member

ujifgc commented Feb 14, 2014

Looks good.

ujifgc added a commit that referenced this pull request Feb 16, 2014
@ujifgc
Merge pull request #1591 from padrino/fix-destroyer
23e145a 
Avoid improper checking, fixes #1584
@ujifgc ujifgc merged commit 23e145a into master Feb 16, 2014
@ujifgc ujifgc deleted the fix-destroyer branch February 16, 2014 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@namusyaka @ujifgc