Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

combine_css breaks background image url due to mis-handling of quotes. #60

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

chris@chrisbeach.co.uk is finding that this:

div#footer { background-image: url( '/images/layout/footerBG.jpg' );
background-repeat: no-repeat }

...gets rewritten to this:

div#footer { background-image: url(http://www.captioncompetition.co.uk/
coreCaption/'/images/layout/footerBG.jpg'); background-repeat: no-
repeat }

...which breaks the image unfortunately

Original issue reported on code.google.com by jmara...@google.com on 9 Nov 2010 at 3:10

@GoogleCodeExporter
Copy link
Author

Thanks for the bug report.  This should not be hard to fix.

Original comment by jmara...@google.com on 9 Nov 2010 at 3:11

@GoogleCodeExporter
Copy link
Author

There are two immediate-term workarounds:

1. remove the spaces, e.g.  
            use               url('/images/layout/footerBG.jpg')
            rather than       url( '/images/layout/footerBG.jpg' )
2. Temporarily disable filter combine_css

Original comment by jmara...@google.com on 9 Nov 2010 at 3:18

@GoogleCodeExporter
Copy link
Author

Sorry for the delay -- the fix made and will be in the next binary release.  
Will update this bug when the fix is submitted to SVN.

Original comment by jmara...@google.com on 19 Nov 2010 at 2:08

@GoogleCodeExporter
Copy link
Author

Fixed in http://code.google.com/p/modpagespeed/source/detail?r=232

Original comment by jmara...@google.com on 19 Nov 2010 at 4:05

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Issue 119 has been merged into this issue.

Original comment by jmara...@google.com on 1 Dec 2010 at 11:42

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant