feat: [IOPID-1521,IOPID-1522,IOPID-1523] Integrate new DS in Profile section #5778
Conversation
…le-app-main-screen
pagopa-github-bot
changed the title
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5778 +/- ##
==========================================
+ Coverage 48.42% 49.82% +1.39%
==========================================
Files 1488 1627 +139
Lines 31617 32322 +705
Branches 7669 7865 +196
==========================================
+ Hits 15311 16103 +792
+ Misses 16238 16156 -82
+ Partials 68 63 -5
... and 543 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ChrisMattew
changed the title
…lity load when needed
…ue, it's not a required prop
…nce action differentProfileLoggedIn is dispatched
| return { | ||
| type: "buttonLink", | ||
| componentProps: { | ||
| onPress: () => { |
There was a problem hiding this comment.
To optimise, you could put the navigation you are using at onPress inside a function that uses the useCallback, what do you think?
There was a problem hiding this comment.
Since the entire object is memoized, the function within it is memoized too. So, wrapping the function with a useCallback is not needed for this use case!
|
@mariateresaventura copy review needed! 🙏🏼 |
Short description
Integrate new DS in Profile section and Tax Code screen.
List of changes proposed in this pull request
Test
E2E
Tip
Screens
iOS & Android
iOS-prifle-new-DS.mov
android-profile-new-ds.mp4
A11Y - iOS & Android
iOS-a11y-profile-new-DS.mov
android-a11y-profile-new-ds.mp4
How to test
Important
Once in the Tax Code screen, if the brightness of your device is not at the maximum level, it will automatically be brought to the maximum level, in this case exiting this screen will restore the brightness of your device as previously set.
Note
** Once the Banner is closed, it shouldn't appear anymore, even if you close and re-open the app. But don't worry, you will still be able to navigate into the "Your Data" screen by clicking on the dedicated item on the list.