-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOBP-647] Latest used method pre-selection #5783
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5783 +/- ##
==========================================
+ Coverage 48.42% 49.71% +1.28%
==========================================
Files 1488 1630 +142
Lines 31617 32418 +801
Branches 7669 7788 +119
==========================================
+ Hits 15311 16116 +805
- Misses 16238 16247 +9
+ Partials 68 55 -13
... and 565 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ts/features/payments/checkout/components/CheckoutPaymentMethodsList.tsx
Outdated
Show resolved
Hide resolved
ts/features/payments/checkout/components/CheckoutPaymentMethodsList.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR implements the logic to pre-select a payment method from the user wallets that have been recently used and will be shown in the appropriate “Recently Used” list item
List of changes proposed in this pull request
updateDate
as more recent;paymentsGetPaymentUserMethodsAction.success
is fired to filter the most recent payment method.How to test
Start a new payment flow with the new payment section feature flag enabled;
When you start a payment, you should be able to see the most recently used payment method pre-selected
Preview
preview.mov