Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOBP-644] Add other onboardable method filters #5785

Merged
merged 12 commits into from
May 29, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 20, 2024

Short description

This PR adds a filter on onboardable methods in the add new method section and a filter on methods with guest payment

List of changes proposed in this pull request

  • Upgraded the API definitions of e-commerce & walletv3;
  • Created a utility function to filter the onboardable methods and guest payment methods;

How to test

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 20, 2024

Affected stories

  • ⚙️ IOBP-644: [Metodi di pagamento] Adeguamento logiche di visualizzazione metodi in app durante i flussi di on-boarding e pagamento
    subtask of
    • IOBP-197: [MVP] Integrazione IO-ecommerce PagoPA (Flusso pagamento)

Generated by 🚫 dangerJS against 484c9de

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 49.71%. Comparing base (4f204b4) to head (484c9de).
Report is 109 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5785      +/-   ##
==========================================
+ Coverage   48.42%   49.71%   +1.28%     
==========================================
  Files        1488     1630     +142     
  Lines       31617    32423     +806     
  Branches     7669     7789     +120     
==========================================
+ Hits        15311    16118     +807     
- Misses      16238    16250      +12     
+ Partials       68       55      -13     
Files Coverage Δ
...tures/payments/onboarding/store/selectors/index.ts 45.45% <0.00%> (+12.12%) ⬆️
...ayments/checkout/store/selectors/paymentMethods.ts 24.39% <0.00%> (ø)
ts/features/payments/onboarding/utils/index.ts 66.66% <33.33%> (-33.34%) ⬇️
ts/features/payments/checkout/utils/index.ts 40.00% <25.00%> (-60.00%) ⬇️

... and 566 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6759f...484c9de. Read the comment docs.

@Hantex9 Hantex9 requested a review from mastro993 May 29, 2024 09:14
Copy link
Contributor

@mastro993 mastro993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hantex9 Hantex9 merged commit 15086be into master May 29, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-644-onboardable-method-filter branch May 29, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants