Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
SHA1
toSHA256
Rationale:
Suggested number of PBKDF2-SHA256 varies, but can reach up to 200,000. However, for performance reasons 50,000 is a good start and should give a bit more protection.
Local performance test [50 times]:
References:
https://docs.python.org/2/library/hashlib.html#hashlib.pbkdf2_hmac
http://security.stackexchange.com/questions/3959/recommended-of-iterations-when-using-pkbdf2-sha256