GPA Improvements: 1.15 to 2.02 #79
Open
+63
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| options[:color] = v | ||
| end | ||
| opts.on("--force-color", "Force use of ANSI color characters even on non-tty outputs (off)") do |v| | ||
| opts.on("--force-color", "Force use of ANSI color characters even on non-tty outputs (off)") do | ||
| options[:force_color] = true | ||
| end | ||
| opts.on("-V", "--version", "Display the version and exit") do |v| |
There was a problem hiding this comment.
Here's another unused block argument.
|
Looks great!
|
|
Agree with everything, had the same thoughts on all subjects. The global |
| - "**.rb" | ||
|
|
||
| exclude_paths: | ||
| - lib/papertrail/okjson.rb |
There was a problem hiding this comment.
I usually avoid adding codeclimate.yml (less clutter), but it is needed if we want to exclude the vendored okjson (which pulls the gpa down quite a bit...)
|
I'll give this a run through next week before merging and cutting a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An assortment of small to medium changes to improve code standards:
okjsonfrom Code ClimateOptionsParserblocksconfigfilemethod toCliHelpersto avoid repeating the confusing condition+assignmentif configfile = find_configfilehttp_clientby adding anattempt times, wait, &blockmethod to handle HTTP retries in a single place.CC: #78